Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description to the page component #143

Merged
merged 2 commits into from
May 12, 2024
Merged

Add description to the page component #143

merged 2 commits into from
May 12, 2024

Conversation

erikzaadi
Copy link
Member

  • Add description to page resource
  • Allow override for running tests

Description

What - Add the missing description property for pages

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)

@erikzaadi erikzaadi force-pushed the PORT-8016-add-description-to-the-page-component-in-terraform-provider-port-labs branch from 1a9e547 to 4b4a7ba Compare May 12, 2024 12:39
@erikzaadi erikzaadi changed the title PORT 8016 add description to the page component in terraform provider port labs Add description to the page component May 12, 2024
Tankilevitch
Tankilevitch approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Makefile Show resolved Hide resolved
port/page/schema.go Outdated Show resolved Hide resolved
@erikzaadi erikzaadi force-pushed the PORT-8016-add-description-to-the-page-component-in-terraform-provider-port-labs branch from 4b4a7ba to 9f7726b Compare May 12, 2024 13:08
@erikzaadi erikzaadi merged commit 9f7726b into main May 12, 2024
3 checks passed
@erikzaadi erikzaadi deleted the PORT-8016-add-description-to-the-page-component-in-terraform-provider-port-labs branch May 12, 2024 13:28
@erikzaadi erikzaadi restored the PORT-8016-add-description-to-the-page-component-in-terraform-provider-port-labs branch May 12, 2024 13:28
@erikzaadi erikzaadi deleted the PORT-8016-add-description-to-the-page-component-in-terraform-provider-port-labs branch May 12, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tankilevitch Tankilevitch Tankilevitch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikzaadi @Tankilevitch