PORT-7217-bug-terraform-errors-when-trying-to-conditionally-set-variable-properties #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
port/action/schema.go
Outdated
Comment on lines
673
to
678
| var asdf = state.UserProperties.As(ctx, userProps, basetypes.ObjectAsOptions{ | ||
| UnhandledNullAsEmpty: true, | ||
| UnhandledUnknownAsEmpty: true, | ||
| }) | ||
| if asdf == nil { | ||
| return |
There was a problem hiding this comment.
give it a proper name
There was a problem hiding this comment.
whoops
this isn't event needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - there was a problem with the automatic type conversion of validations in some cases
How - fixed by adding a new type specifically made for the action validations, and a somewhat manual conversion of the user data to that type
Type of change
Please leave one option from the following and delete the rest: