Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port 6051 terraform provider values in scorecard rules #106

Merged

Conversation

talsabagport
Copy link
Contributor

Description

What - Allow json string scorecard condition to support all permutations dynamically (including different values types for example)

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/resources/port_scorecard.md Show resolved Hide resolved
@talsabagport talsabagport merged commit 1947767 into main Jan 21, 2024
3 checks passed
@talsabagport talsabagport deleted the PORT-6051-terraform-provider-values-in-scorecard-rules branch January 21, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants