fixed the schema and refreshActionState

port-labs · Nov 15, 2023 · ba3aec6 · ba3aec6
1 parent ad683b7
commit ba3aec6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/port/action/refreshActionState.go b/port/action/refreshActionState.go
@@ -99,6 +99,8 @@ func writeVisibleToResource(v cli.ActionProperty) (types.Bool, types.String) {
 		jqQueryValue := jq["jqQuery"].(string)
 		return types.BoolNull(), flex.GoStringToFramework(&jqQueryValue)
 	}
+
+	return types.BoolNull(), types.StringNull()
 }
 
 func writeInputsToResource(ctx context.Context, a *cli.Action, state *ActionModel) error {
@@ -254,7 +256,7 @@ func refreshActionState(ctx context.Context, state *ActionModel, a *cli.Action,
 }
 
 func setCommonProperties(ctx context.Context, v cli.ActionProperty, prop interface{}) error {
-	properties := []string{"Description", "Icon", "Default", "Title", "DependsOn", "Dataset"}
+	properties := []string{"Description", "Icon", "Default", "Title", "DependsOn", "Dataset", "Visible"}
 	for _, property := range properties {
 		switch property {
 		case "Description":

diff --git a/port/action/schema.go b/port/action/schema.go
@@ -331,7 +331,7 @@ func StringPropertySchema() schema.Attribute {
 			MarkdownDescription: "The visibility condition jq query of the string property",
 			Optional:            true,
 			Validators: []validator.String{
-				stringvalidator.ConflictsWith(path.MatchRelative().AtParent().AtName("enum")),
+				stringvalidator.ConflictsWith(path.MatchRelative().AtParent().AtName("visible")),
 			},
 		},
 	}
@@ -391,7 +391,7 @@ func NumberPropertySchema() schema.Attribute {
 			MarkdownDescription: "The visibility condition jq query of the number property",
 			Optional:            true,
 			Validators: []validator.String{
-				stringvalidator.ConflictsWith(path.MatchRelative().AtParent().AtName("enum")),
+				stringvalidator.ConflictsWith(path.MatchRelative().AtParent().AtName("visible")),
 			},
 		},
 	}
@@ -427,7 +427,7 @@ func BooleanPropertySchema() schema.Attribute {
 			MarkdownDescription: "The visibility condition jq query of the boolean property",
 			Optional:            true,
 			Validators: []validator.String{
-				stringvalidator.ConflictsWith(path.MatchRelative().AtParent().AtName("enum")),
+				stringvalidator.ConflictsWith(path.MatchRelative().AtParent().AtName("visible")),
 			},
 		},
 	}
@@ -470,7 +470,7 @@ func ObjectPropertySchema() schema.Attribute {
 			MarkdownDescription: "The visibility condition jq query of the object property",
 			Optional:            true,
 			Validators: []validator.String{
-				stringvalidator.ConflictsWith(path.MatchRelative().AtParent().AtName("enum")),
+				stringvalidator.ConflictsWith(path.MatchRelative().AtParent().AtName("visible")),
 			},
 		},
 	}
@@ -602,7 +602,7 @@ func ArrayPropertySchema() schema.Attribute {
 			MarkdownDescription: "The visibility condition jq query of the array property",
 			Optional:            true,
 			Validators: []validator.String{
-				stringvalidator.ConflictsWith(path.MatchRelative().AtParent().AtName("enum")),
+				stringvalidator.ConflictsWith(path.MatchRelative().AtParent().AtName("visible")),
 			},
 		},
 	}