fixed a typo and improved tests

port-labs · Sep 8, 2024 · 5ef9011 · 5ef9011
1 parent dafdcdb
commit 5ef9011
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 3 deletions.
diff --git a/port/action/actionStateToPortBody.go b/port/action/actionStateToPortBody.go
@@ -167,7 +167,7 @@ func triggerToBody(ctx context.Context, data *ActionModel) (*cli.Trigger, error)
 
 		if data.AutomationTrigger.RunCreatedEvent != nil {
 			automationTrigger.Event = &cli.TriggerEvent{
-				Type:             consts.RunUpdated,
+				Type:             consts.RunCreated,
 				ActionIdentifier: data.AutomationTrigger.RunCreatedEvent.ActionIdentifier.ValueStringPointer(),
 			}
 		}
@@ -181,7 +181,7 @@ func triggerToBody(ctx context.Context, data *ActionModel) (*cli.Trigger, error)
 
 		if data.AutomationTrigger.AnyRunChangeEvent != nil {
 			automationTrigger.Event = &cli.TriggerEvent{
-				Type:             consts.RunUpdated,
+				Type:             consts.AnyRunChange,
 				ActionIdentifier: data.AutomationTrigger.AnyRunChangeEvent.ActionIdentifier.ValueStringPointer(),
 			}
 		}

diff --git a/port/action/model.go b/port/action/model.go
@@ -324,7 +324,7 @@ type AutomationTriggerModel struct {
 	TimerPropertyExpiredEvent *TimerPropertyExpiredEventModel `tfsdk:"timer_property_expired_event"`
 	RunCreatedEvent           *RunCreatedEvent                `tfsdk:"run_created_event"`
 	RunUpdatedEvent           *RunUpdatedEvent                `tfsdk:"run_updated_event"`
-	AnyRunChangeEvent         *AnyRunChangeEvent              `tfsdk:"any_run_chnage_event"`
+	AnyRunChangeEvent         *AnyRunChangeEvent              `tfsdk:"any_run_change_event"`
 	JqCondition               *JqConditionModel               `tfsdk:"jq_condition"`
 }
 

diff --git a/port/action/resource_test.go b/port/action/resource_test.go
@@ -1608,6 +1608,12 @@ func TestAccPortAutomationRunCreated(t *testing.T) {
 					resource.TestCheckResourceAttr("port_action.create_microservice", "automation_trigger.run_created_event.action_identifier", "self_serve_action"),
 				),
 			},
+			{
+				ResourceName:      "port_action.create_microservice",
+				ImportState:       true,
+				ImportStateVerify: true,
+				ImportStateId:     actionIdentifier,
+			},
 		},
 	})
 }
@@ -1653,6 +1659,12 @@ func TestAccPortAutomationRunUpdated(t *testing.T) {
 					resource.TestCheckResourceAttr("port_action.create_microservice", "automation_trigger.run_updated_event.action_identifier", "self_serve_action"),
 				),
 			},
+			{
+				ResourceName:      "port_action.create_microservice",
+				ImportState:       true,
+				ImportStateVerify: true,
+				ImportStateId:     actionIdentifier,
+			},
 		},
 	})
 }
@@ -1698,6 +1710,12 @@ func TestAccPortAutomationAnyRunChange(t *testing.T) {
 					resource.TestCheckResourceAttr("port_action.create_microservice", "automation_trigger.any_run_change_event.action_identifier", "self_serve_action"),
 				),
 			},
+			{
+				ResourceName:      "port_action.create_microservice",
+				ImportState:       true,
+				ImportStateVerify: true,
+				ImportStateId:     actionIdentifier,
+			},
 		},
 	})
 }