Port 9402 port api search identifier #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsinai
requested changes
Aug 25, 2024
|
|
||
| func (f *fixture) assertObjectsHandled(objects []struct{ kind, name string }) { | ||
| assert.Eventually(f.t, func() bool { | ||
| integrationKinds, err := f.portClient.GetIntegrationKinds(f.controllersHandler.stateKey) |
omby8888
approved these changes
Aug 26, 2024
pkg/jq/parser_test.go
Outdated
There was a problem hiding this comment.
add a test on search identifier
danielsinai
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Add support for search identifier feature
Why - Allows you to update entity without knowing its identifier
How - Refactor the code to allow run initial sync independently, which then can be used to evaluate and keep the identifiers while running initial sync to Port. The identifiers needed for the delete stale entities process at the end of the initial resync.
Type of change
Please leave one option from the following and delete the rest: