Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crd autodiscovery nested schema support #65

Merged
merged 21 commits into from
May 19, 2024

Conversation

danielsinai
Copy link
Contributor

Description

What -
Why -
How -

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

Copy link
Contributor

@talsabagport talsabagport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Left few comments. Brilliant feature and work :)

pkg/port/cli/action.go Outdated Show resolved Hide resolved
pkg/crd/crd.go Show resolved Hide resolved
pkg/crd/crd.go Outdated Show resolved Hide resolved
pkg/crd/crd.go Outdated Show resolved Hide resolved
pkg/crd/crd.go Show resolved Hide resolved
pkg/crd/crd.go Show resolved Hide resolved
pkg/crd/crd.go Show resolved Hide resolved
pkg/crd/crd.go Outdated Show resolved Hide resolved
@danielsinai danielsinai merged commit d7e6140 into main May 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants