Add items to parse functionallity to the mappings

[itamar-smirra-port]

Description

What - Add items to parse functionallity to the mappings
Why - To ingest inner entities from base resource

Type of change

Please leave one option from the following and delete the rest:

• New feature (non-breaking change which adds functionality)

The current mapping:

port:
      itemsToParse: .spec.template.spec.containers
      entity:
        mappings:
          - identifier: .item.name + "-Container"
            title: .item.name
            blueprint: '"container"'
            icon: '"Deployment"'
            properties:
              image: .item.image
            relations:
              deployment: .metadata.name + "-Deployment-" + .metadata.namespace

Will ingest the containers inside a Kubernetes deployment.
Example deployment yaml with two containers:

apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    deployment.kubernetes.io/revision: "2"
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"apps/v1","kind":"Deployment","metadata":{"annotations":{},"labels":{"app":"nginx"},"name":"nginx-deployment","namespace":"default"},"spec":{"replicas":3,"selector":{"matchLabels":{"app":"nginx"}},"template":{"metadata":{"labels":{"app":"nginx"}},"spec":{"containers":[{"image":"nginx:1.14.2","name":"nginx","ports":[{"containerPort":80}]}]}}}}
  creationTimestamp: "2024-04-11T14:28:11Z"
  generation: 2
  labels:
    app: nginx
    itamar: hamelech
  name: nginx-deployment
  namespace: default
  resourceVersion: "17669"
  uid: 177fb3eb-fcab-4ae0-b8e9-87fc927d9f03
spec:
  progressDeadlineSeconds: 600
  replicas: 3
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      app: nginx
  strategy:
    rollingUpdate:
      maxSurge: 25%
      maxUnavailable: 25%
    type: RollingUpdate
  template:
    metadata:
      creationTimestamp: null
      labels:
        app: nginx
    spec:
      containers:
      - image: nginx:1.14.2
        imagePullPolicy: IfNotPresent
        name: nginx
        ports:
        - containerPort: 80
          protocol: TCP
        resources: {}
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: File
      - image: itamar:1.14.2
        imagePullPolicy: IfNotPresent
        name: itamar
        ports:
        - containerPort: 80
          protocol: TCP
        resources: {}
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: File
      dnsPolicy: ClusterFirst
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext: {}
      terminationGracePeriodSeconds: 30
status:
  availableReplicas: 3
  conditions:
  - lastTransitionTime: "2024-04-11T14:28:20Z"
    lastUpdateTime: "2024-04-11T14:28:20Z"
    message: Deployment has minimum availability.
    reason: MinimumReplicasAvailable
    status: "True"
    type: Available
  - lastTransitionTime: "2024-04-11T15:51:32Z"
    lastUpdateTime: "2024-04-11T15:51:32Z"
    message: ReplicaSet "nginx-deployment-5b8b448b96" has timed out progressing.
    reason: ProgressDeadlineExceeded
    status: "False"
    type: Progressing
  observedGeneration: 2
  readyReplicas: 3
  replicas: 4
  unavailableReplicas: 1
  updatedReplicas: 1

Will create in Port:

[yairsimantov20]

comments

[yairsimantov20]

Suggested change

	ItemsToParse string `json:"ItemsToParse"`
	ItemsToParse string `json:"itemsToParse"`

[yairsimantov20]

i think we need to add support for yaml in here

[itamar-smirra-port]

In general or just for the itemsToParse?
If in general it maybe be better to create separate task for it.

[yairsimantov20]

its not that big of a deal
just add yaml:"" and the name should be same as json

[itamar-smirra-port]

Got it, done.

[yairsimantov20]

we talked about it
yaml

[itamar-smirra-port]

Done

[yairsimantov20]

this if is redundant
instead always runs the loop and set the single value to an array in case there is no items to parse

[itamar-smirra-port]

I need the if so I can check wether the items array parsing is needed, but I had fix it to use only one loop as you suggest with the nice idea of insert the single object into array.
Let me know if that what you meant.

[itamar-smirra-port]

Apparently I had a problem with this solution, that because the items were overriding each other so only the last item was mapped to entity in the later for loop.
I revert it back to map the item to an entity in each item so it would not happened.
Another solution will be to clone each item to the edited object before insert it to the objectsToMap array but there is no build in clone method for Go so I figured it is a bit overkill.

[yairsimantov20]

we talked about this

[itamar-smirra-port]

Done

[yairsimantov20]

🌊