Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added OverwriteConfigurationOnRestart configuration #38

Conversation

yairsimantov20
Copy link
Contributor

@yairsimantov20 yairsimantov20 commented Feb 8, 2024

Description

What - Customers want to control the exporter config from their config map and not from port
Why - IAC
How - Added the OverwriteConfigurationOnRestart flag to allow the exporter to apply the config to port on each boot

Type of change

  • New feature (non-breaking change which adds functionality)

@yairsimantov20 yairsimantov20 changed the title added UsePortUIConfig configuration added OverwriteConfigurationOnRestart configuration Feb 8, 2024
Copy link
Contributor

@talsabagport talsabagport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a test or at least make the relevant adaptations to the Test_InitIntegration_DeprecatedResourcesConfiguration test

pkg/config/config.go Outdated Show resolved Hide resolved
pkg/port/models.go Outdated Show resolved Hide resolved
pkg/port/models.go Outdated Show resolved Hide resolved
@yairsimantov20 yairsimantov20 merged commit 8867e51 into main Feb 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants