Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PORT-5940 fix k 8 s exporter binaries for amd #33

Merged
merged 17 commits into from
Jan 3, 2024

Conversation

yairsimantov20
Copy link
Contributor

@yairsimantov20 yairsimantov20 commented Jan 2, 2024

Updated the release process with a seperate docker file for x86_64 arch with additional required dependencies

Discovered the issue by following these steps:

  • changing base image to alpine to allow more debug and installation commands
  • ran ldd /usr/bin/port-k8s-exporter to detect missing binaries
  • installed the missing binary (/lib64/ld-linux-x86-64.so.2) with apk add gcompat
  • separated docker file to x86_64 file and arm file for different dependencies

Should resolve #32 & port-labs/helm-charts#66

@MPTG94 MPTG94 changed the title Port 5940 fix k 8 s exporter binaries for amd PORT-5940 fix k 8 s exporter binaries for amd Jan 2, 2024
Copy link
Member

@MPTG94 MPTG94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yairsimantov20 yairsimantov20 merged commit 07e908a into main Jan 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Looks like the image doesn't work
2 participants