Make actor pad automagically calculated #4528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, we had to manually update the actor pad size if the size of pony_actor_t changed. This commit makes it so that the actor pad size is now automagically calculated by the compiler so it doesn't have to be manually maintained any longer.
ponylang-main
added
the
discuss during sync
jemc
approved these changes
Oct 15, 2024
jemc
requested changes
Oct 15, 2024
There was a problem hiding this comment.
Initially approved because it is correct, but on the sync call we discussed that it might add some safety to add after the last member of pony_actor_t (that is, between line 70 and 71) a comment that says something like "if you add more members here, you need to update the PONY_ACTOR_PAD_SIZE calculation below, to reference the final member, its offset, and size)"
This will help prevent future subtle mistakes
|
added the warning |
jemc
approved these changes
Oct 15, 2024
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, we had to manually update the actor pad size if the size of pony_actor_t changed.
This commit makes it so that the actor pad size is now automagically calculated by the compiler so it doesn't have to be manually maintained any longer.