-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribution and doc build guidelines #3905
base: main
Are you sure you want to change the base?
Conversation
What does this mean? what process? |
There's only 1 file in this PR. I think you missed adding something. |
I did not change the CI process and only added the one file at this time with the proposed method for inserting this PR's index.md in the correct place. I ran out of time tonight to fix the missing blank line between the end of this PR's index.md and the start of the ponyc public docs generator's index.md. If having the two sed lines is a good solution, I will edit the CI process to match and include it in this PR. That will fix statement of mine that you quoted. (I also now see how confusingly written that statement was on reading it now.) |
So there is currently an "index page" of some sort. what would the change be? i'm unclear. Can you give an example of existing content and what it would be afterwards or perhaps the changes to the stdlib generation so I can understand where this index would go and how it would be "seded" in. I'm not following at moment from the original description. |
The change is adding the content from a new This is what is in my Building Documentation Locally subsection of the committed file. Whatever is in |
@rhagenson should this be closed? |
Will close #1829 when merged.
Had to use a bit of
sed
to insert a "fake" index page in the correct place.Improvements as I see them prior to merging:
sed
to insert at the top of the file is dropping the final blank line from the incomingindex.md
-- we need this blank line to be copied or a new blank be added otherwise "Packages" will be put in the final paragraph on the MkDocsindex.md