Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web.js refactoring #222

Merged
merged 26 commits into from
May 25, 2024
Merged

web.js refactoring #222

merged 26 commits into from
May 25, 2024

Conversation

shaedrich
Copy link
Contributor

@shaedrich shaedrich commented May 22, 2024

Fixes #218

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label May 22, 2024
@shaedrich shaedrich marked this pull request as ready for review May 22, 2024 15:26
shaedrich added a commit to shaedrich/pony-playground that referenced this pull request May 22, 2024
Copy link
Member

@jemc jemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this PR, I've already reviewed all your changes, so don't decompose it now...

But for future PRs, please try to keep to one "kind" of fix per PR (e.g. one PR to change var to const or let, another PR to change how URL params are handled, etc), to make it easier to review (and revert, if needed) your changes.

For this time, I think we can merge it after you remove the stray commented-out line below.

static/web.js Outdated Show resolved Hide resolved
@jemc
Copy link
Member

jemc commented May 22, 2024

Heads up to anyone watching the git history: I'm going to "true merge" this one instead of "squash and merge", because the individual commit messages look like individually relevant changes with reasonable commit messages, making it easier to potentially revert parts of this PR if needed.

@jemc jemc merged commit a08532f into ponylang:main May 25, 2024
5 checks passed
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label May 25, 2024
@shaedrich shaedrich deleted the web-js-refactoring branch May 25, 2024 11:29
jemc added a commit that referenced this pull request May 28, 2024
…ippet from URL by file name (#205)

See ponylang/pony-tutorial#340

> [!WARNING]
Will only work, after #222 has been merged.

Example: https://playground.ponylang.io/?snippet=hello-world-main.pony

Co-authored-by: Joe Eli McIlvain <[email protected]>

---------

Co-authored-by: Matthias Wahl <[email protected]>
Co-authored-by: Joe Eli McIlvain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor getQueryParameters() to use URL/URLSearchParams
3 participants