-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web.js refactoring #222
web.js refactoring #222
Conversation
instead of custom solution
instead of creating anonymous function wrappers for callback function calls
to be more descriptive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this PR, I've already reviewed all your changes, so don't decompose it now...
But for future PRs, please try to keep to one "kind" of fix per PR (e.g. one PR to change var
to const
or let
, another PR to change how URL params are handled, etc), to make it easier to review (and revert, if needed) your changes.
For this time, I think we can merge it after you remove the stray commented-out line below.
Co-authored-by: Joe Eli McIlvain <[email protected]>
Heads up to anyone watching the git history: I'm going to "true merge" this one instead of "squash and merge", because the individual commit messages look like individually relevant changes with reasonable commit messages, making it easier to potentially revert parts of this PR if needed. |
…ippet from URL by file name (#205) See ponylang/pony-tutorial#340 > [!WARNING] Will only work, after #222 has been merged. Example: https://playground.ponylang.io/?snippet=hello-world-main.pony Co-authored-by: Joe Eli McIlvain <[email protected]> --------- Co-authored-by: Matthias Wahl <[email protected]> Co-authored-by: Joe Eli McIlvain <[email protected]>
Fixes #218
??
)String.prototype.localeCompare()
Function.prototype.bind()
dataset
propertyclassList
property===
)/strict inequality (!==
)KeyboardEvent.code
instead of deprecatedKeyboardEvent.keyCode
fetch()
instead ofXMLHttpRequest