Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5/?] Add ability to run code examples in the playground: Add CORS exception for tutorial.ponylang.io to route /evaluate.json #212

Merged
merged 8 commits into from
Jun 30, 2024
Merged

[5/?] Add ability to run code examples in the playground: Add CORS exception for tutorial.ponylang.io to route /evaluate.json #212

merged 8 commits into from
Jun 30, 2024

Conversation

shaedrich
Copy link
Contributor

@shaedrich shaedrich commented Apr 30, 2024 •
edited
Loading

See ponylang/pony-tutorial#340

As discussed in #205

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Apr 30, 2024
@shaedrich shaedrich mentioned this pull request Apr 30, 2024
Open
@shaedrich shaedrich changed the title Add CORS exception for tutorial.ponylang.io to rout /evaluate.json [4/?] Add ability to run code examples in the playground: Add CORS exception for tutorial.ponylang.io to rout /evaluate.json Apr 30, 2024
@shaedrich shaedrich mentioned this pull request Apr 30, 2024
Closed
@jemc
Copy link
Member

jemc commented May 14, 2024

Looks good to me. I can approve after it's no longer a draft.

@shaedrich shaedrich changed the title [4/?] Add ability to run code examples in the playground: Add CORS exception for tutorial.ponylang.io to rout /evaluate.json [4/?] Add ability to run code examples in the playground: Add CORS exception for tutorial.ponylang.io to route /evaluate.json May 15, 2024
@shaedrich shaedrich changed the title [4/?] Add ability to run code examples in the playground: Add CORS exception for tutorial.ponylang.io to route /evaluate.json [5/?] Add ability to run code examples in the playground: Add CORS exception for tutorial.ponylang.io to route /evaluate.json May 20, 2024
@jemc jemc removed the discuss during sync Should be discussed during an upcoming sync label May 21, 2024
@shaedrich shaedrich marked this pull request as ready for review May 22, 2024 18:22
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label May 22, 2024
jemc
jemc reviewed May 25, 2024
View reviewed changes
src/api.rs Outdated Show resolved Hide resolved
@shaedrich @jemc
Change let to const
570f0b5 
Co-authored-by: Joe Eli McIlvain <[email protected]>
@jemc
Copy link
Member

jemc commented May 31, 2024

Looks like there's a parsing issue in the CI failure.

@shaedrich
Copy link
Contributor Author

It's fixed now.

This was referenced Jun 4, 2024
Draft
Draft
@jemc
Copy link
Member

jemc commented Jun 11, 2024

Looks like there are still Rust formatting changes that need to happen before CI will pass.

This is otherwise good to go 👍

@shaedrich
Copy link
Contributor Author

Done

@SeanTAllen
Copy link
Member

This is failing cargo checks.

@SeanTAllen
Copy link
Member

@mfelsche do you know what needs to happen for this?

@SeanTAllen SeanTAllen removed the discuss during sync Should be discussed during an upcoming sync label Jun 25, 2024
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Jun 25, 2024
@jemc jemc removed the discuss during sync Should be discussed during an upcoming sync label Jun 25, 2024
mfelsche
mfelsche requested changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@mfelsche mfelsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs a dependency on tower_http added to Cargo.toml like so:

tower-http = { version = "0.5", features = ["cors"] }

src/api.rs Outdated Show resolved Hide resolved
src/api.rs Outdated Show resolved Hide resolved
shaedrich and others added 2 commits June 30, 2024 13:11
@shaedrich @mfelsche
Fix HeaderValue import
4d8e628 
Co-authored-by: Matthias Wahl <[email protected]>
@shaedrich
Add dependency
905c4af 
Co-authored-by: Matthias Wahl <[email protected]>

As per ponylang#212 (review)
@shaedrich shaedrich requested a review from mfelsche June 30, 2024 11:27
mfelsche
mfelsche approved these changes Jun 30, 2024
View reviewed changes
Copy link
Contributor

@mfelsche mfelsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfelsche mfelsche merged commit 2297589 into ponylang:main Jun 30, 2024
6 checks passed
@shaedrich shaedrich deleted the tutorial-cors branch June 30, 2024 14:14
@mfelsche
Copy link
Contributor

@shaedrich this is live now on https://playground.ponylang.io

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Jun 30, 2024
@shaedrich
Copy link
Contributor Author

shaedrich commented Jun 30, 2024 •
edited
Loading

@mfelsche Cool, thanks for deploying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemc jemc jemc approved these changes

@mfelsche mfelsche mfelsche approved these changes

Assignees
No one assigned
Labels
discuss during sync Should be discussed during an upcoming sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shaedrich @jemc @SeanTAllen @mfelsche @ponylang-main