Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pony Playground doen't update for #268

Closed
Dhruv-mak opened this issue Oct 6, 2024 · 6 comments · Fixed by #269
Closed

Pony Playground doen't update for #268

Dhruv-mak opened this issue Oct 6, 2024 · 6 comments · Fixed by #269

Comments

@Dhruv-mak
Copy link

Hi,
The pony playground doesn't update after making any changes. Here's the link to the playground: https://playground.ponylang.io/?gist=c9a683a0e53926227b4414aa3b33e277
I'ts stuck to the default code. Here's my system specifications.
OS: Arch Linux x86_64
Host: Strix 15 GL503GE 1.0
Kernel: 6.11.1-arch1-1
Browser : Firefox Browser 131.0 (64-bit)

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Oct 6, 2024
@mfelsche
Copy link
Contributor

mfelsche commented Oct 6, 2024

The playground, doesn't automatically update its URL, when the text is updated.
What it does is creating a gist, when hitting the "Share" button and setting creating a permalink to the current state of the playground in the right "result" area. Share this URL instead of the current one in the address bar.

Do you think it would be more intuitive, if the playground were showing the following behaviour:

Upon hitting the "Share" button, the current URL in the address-bar switches to the one created for the current t state.

@Dhruv-mak
Copy link
Author

Dhruv-mak commented Oct 6, 2024

I'm not sure if I understood correctly, but I think the gist itself is not getting updated. Current behavior is that even after updating the code, both the permalink and github gist has the old content when it was first clicked. Clicking share again doesn't change that behavior.

@SeanTAllen
Copy link
Member

@SeanTAllen
Copy link
Member

@mfelsche I can replicate this bug.

@SeanTAllen
Copy link
Member

We believe this is fixed by #269. @Dhruv-mak can you verify that it is working for you now? (I installed the code for #269 to production so even though the PR isn't merged, it is live.

@Dhruv-mak
Copy link
Author

@SeanTAllen It is updating every time I click on share. Thanks.

@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants