Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with gist sharing and ASM and LLVM IR compilation #269

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Fix bug with gist sharing and ASM and LLVM IR compilation #269

merged 3 commits into from
Oct 7, 2024

Conversation

mfelsche
Copy link
Contributor

@mfelsche mfelsche commented Oct 7, 2024

Using .bind() for the button callbacks was using the editor content at the time bind() was called, not upon click.

Should fix #268

@mfelsche mfelsche added bug Something isn't working changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge labels Oct 7, 2024
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Oct 7, 2024
@SeanTAllen SeanTAllen mentioned this pull request Oct 7, 2024
Closed
@mfelsche mfelsche merged commit 463cee9 into main Oct 7, 2024
4 checks passed
@mfelsche mfelsche deleted the sharing-bug branch October 7, 2024 19:37
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pony Playground doen't update for
2 participants
@mfelsche @ponylang-main