Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionExtension, ExtrinsicV5 #5976

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

TransactionExtension, ExtrinsicV5 #5976

wants to merge 22 commits into from

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Sep 6, 2024

ref: paritytech/polkadot-sdk#3685

WIP

ExtrinsicV4

  • Signed Transactions Work
  • Unsigned Transaction Work
  • No breaking Changes
    • Ensure there are no breaking changes in the current extrinsic construction workflow. This should only be checked off when this PR is ready to be merged.

ExtrinsicV5

  • Signed Transactions Work
    • All payloads are hashed with blake2b
    • Encodes signing payload correctly
    • Decodes signing payload correctly
    • Constructs and injects signatures correctly
  • General Transaction Work
    • Decode
    • Encode
  • Bare Transaction Work

@bee344
Copy link
Member

bee344 commented Sep 20, 2024

Something strange happens when I submit a general throught txwrapper: In the terminal I get

Error: 1002 Verification Error: Runtime error: Execution failed: Execution aborted due to trap: wasm trap: wasm unreachable instruction executed
WASM backtrace:
error while executing at wasm backtrace:
    0: 0x6894f9 - rococo_runtime.wasm!rust_begin_unwind
    1: 0x12111 - rococo_runtime.wasm!core::panicking::panic_fmt::h791724d28dc2b8fe
    2: 0x5ac45a - rococo_runtime.wasm!TaggedTransactionQueue_validate_transaction: "RuntimeApi(\"Execution failed: Execution aborted due to trap: wasm trap: wasm unreachable`instruction executed\\nWASM backtrace:\\nerror while executing at wasm backtrace:\\n    0: 0x6894f9 - rococo_runtime.wasm!rust_begin_unwind\\n    1: 0x12111 - rococo_runtime.wasm!core::panicking::panic_fmt::h791724d28dc2b8fe\\n    2: 0x5ac45a - rococo_runtime.wasm!TaggedTransactionQueue_validate_transaction\")"
    at /home/bee344/Documentos/parity/txwrapper-core/packages/txwrapper-examples/lib/txwrapper-examples/common/util.js:33:19
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async main (/home/bee344/Documentos/parity/txwrapper-core/packages/txwrapper-examples/lib/txwrapper-examples/polkadot/src/polkadot.js:110:26)

But when I submit the same hex through apps author.submitExtrinsic I get

1011: Unknown Transaction Validity: UnknownTransaction::NoUnsignedValidator

No idea why though.

Tested with https://github.com/paritytech/txwrapper-core/tree/anp-test-transaction-ext . Last two commits work with the last two commits here, but for some reason general doesn't work with signed and viceversa

@gui1117
Copy link

gui1117 commented Sep 20, 2024

AFAICT NoUnsignedValidator is only possible to be returned by bare extrinsic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants