Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ParachainHost to api version 10 on kusama #204

Conversation

alexggh
Copy link
Contributor

@alexggh alexggh commented Feb 28, 2024

... to add approval_voting_params API which will allow us to enable approvals coalescing implementation from:

Note! Bumping the version will not enable the new logic, that will be enable at a later date we we decide to call set_approval_voting_params with max_approval_coalesce_count greater than 1.

... to add approval_voting_params API which will allow us to enable
approvals coalescing implementation from:
 - paritytech/polkadot-sdk#1191

Note! Bumping the version will not enable the new logic, that will be
enable at a later date we we decide to call set_approval_voting_params
with max_approval_coalesce_count greater than 1.

Signed-off-by: Alexandru Gheorghe <[email protected]>
@alexggh alexggh force-pushed the alexaggh/approvals_coalesce_count branch from d5a3f2d to 7f8b6db Compare February 28, 2024 08:14
Signed-off-by: Alexandru Gheorghe <[email protected]>
@alexggh
Copy link
Contributor Author

alexggh commented Feb 28, 2024

@bkontur any idea if the following failed check, is something to worry about ? It did not start with this PR, but better ask than being sorry :D

Check Migrations / check-migrations (encointer-kusama, encointer-kusama-runtime, system

@bkontur
Copy link
Contributor

bkontur commented Feb 28, 2024

@bkontur any idea if the following failed check, is something to worry about ? It did not start with this PR, but better ask than being sorry :D

Check Migrations / check-migrations (encointer-kusama, encointer-kusama-runtime, system

@alexggh no worries, it is a known issue: #159 (comment)

@alexggh
Copy link
Contributor Author

alexggh commented Feb 28, 2024

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) February 28, 2024 10:35
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@alexggh
Copy link
Contributor Author

alexggh commented Feb 29, 2024

@alexggh no worries, it is a known issue: #159 (comment)

Yeah, but it seems I can't merge the stuff without it passing because it is required, @bkchr any chance you can use your super powers to merge this. Thank you!

@fellowship-merge-bot fellowship-merge-bot bot merged commit 0718945 into polkadot-fellows:main Feb 29, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants