chore: refactor code #497
Merged
chore: refactor code #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying dashboard with
|
| Latest commit: |
d77ddd5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fafbc012.dashboard-a6v.pages.dev |
| Branch Preview URL: | https://nik-refactor-code.dashboard-a6v.pages.dev |
peetzweg
reviewed
Aug 30, 2024
Comment on lines
+33
to
+34
| const reusableH1 = | ||
| 'font-unbounded text-primary flex-1 shrink-0 whitespace-nowrap text-xl font-semibold tracking-tight sm:grow-0' |
There was a problem hiding this comment.
Why like this and not also similar to main in index.css
h1 {
@apply font-unbounded text-primary flex-1 shrink-0 whitespace-nowrap text-xl font-semibold tracking-tight sm:grow-0;
}I don't see any benefit to doing this and just causes confusion what to use.
It will still be extendable on demand via className prop.
There was a problem hiding this comment.
Thats ok. It was forgotten. Will fix in later pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #496