-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support auto reply handling #1663
base: main
Are you sure you want to change the base?
Conversation
); | ||
|
||
drop index todos_partial_idx; | ||
create index todos_partial_idx on campaign_contact (campaign_id, assignment_id, message_status, is_opted_out, auto_reply_eligible) where (archived = false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Highlighting that this adds auto_reply_eligible
to todos_partial_idx
. I think this is a good move because the field is functionally pretty similar to is_opted_out
but welcome any thoughts otherwise!
9870a31
to
7cd7433
Compare
@bchrobot @hiemanshu the failing test here requires |
The easy route is to do something similar to what we do in Switchboard: separating the config object itself from the parsed environment variables: Another option is to use Jest mocks. I have struggled to make this to work for specific object properties before, but this approach might work: https://stackoverflow.com/a/67897729 |
To add to what Chrobot said above, we should have a different config for tests, that enables all the flags possible. We should test with all possible features turned on. |
@ajohn25 would you update the SQL schema dump? Having a hard time reviewing the auto-assignment views migration on its own |
@bchrobot sorry i converted this back to draft to address a few things i thought of - one of those being that |
7cd7433
to
063fda4
Compare
Description
This PR adds all backend changes required to support auto reply handling.
This does not expose any auto reply functionality to users intentionally, to allow for an easier slow rollout of this feature if desired.
Motivation and Context
Part 1 of 2 for #1526
How Has This Been Tested?
See
message-sending.spec.ts
Screenshots (if appropriate):
Documentation Changes
Checklist: