chore(node)!: update 16.14 -> 18.16 #1600
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lediur
force-pushed
the
chore/update-node-18
branch
from
5a040b7
to
74d1276
Compare
hiemanshu
changed the title
hiemanshu
changed the title
hiemanshu
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
hot-shotsfrom 8.3.0 to 10.0.0 to resolve an incompatibility with Node 18 (native V8 interface mismatch withhot-shotsdependencyunix-dgram, see Upgrade to unix-dgram 2.0.6 for node 18 support brightcove/hot-shots#235)Motivation and Context
Resolves #1554
How Has This Been Tested?
Locally, with
NODE_ENV=test yarn jest --forceExit --detectOpenHandles src/**/*Screenshots (if appropriate):
N/A
Documentation Changes
No user-facing changes. Contributor-facing changes included.
Checklist: