fix: Migrate to PyO3 0.22 and released verion of rust-numpy crate #19199
+109
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng deprecated, and rather than investigating one by one if it's necessary, I just matched the current behavior in a way that suppresses warnings.
…ackwards compatibility.
You can opt-in with a feature, but that requires the GIL to be held or it panics, so it didn't actually work even if it compiled. So I just switched to the new API requirement.
github-actions
bot
added
fix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19199 +/- ##
==========================================
+ Coverage 79.64% 79.67% +0.02%
==========================================
Files 1532 1532
Lines 209131 209206 +75
Branches 2416 2416
==========================================
+ Hits 166570 166677 +107
+ Misses 42015 41983 -32
Partials 546 546 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17273
This also tweaks the abi3 in the
polars-pythoncrate to match what was in py-polars (3.9), since Python 3.8 is now EOL.The commits are a commit per category of change I made.