ci: Revert "feat(python): Raise an error when users try to use Polars API in a fork()-without-execve() child (#19149) #19188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in a fork()-without-execve() child (pola-rs#19149)" This reverts commit 48bc09b.
nameexhaustion
changed the title
github-actions
bot
added
title needs formatting
internal
nameexhaustion
changed the title
nameexhaustion
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19188 +/- ##
=======================================
Coverage 79.65% 79.65%
=======================================
Files 1531 1531
Lines 208937 208925 -12
Branches 2418 2415 -3
=======================================
- Hits 166421 166417 -4
+ Misses 41969 41962 -7
+ Partials 547 546 -1 ☔ View full report in Codecov by Sentry. |
|
cc @itamarst |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
|
Alright. Let's revert for now, it seems like tricky business. |
|
Another approach would be a warning on fork, the way Jax does it. It's not as thorough and people can not notice warnings, but it's something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 48bc09b to fix the Python docs build.
IIUC the commit replaces everything in the
plnamespace with a dummy function, and I'm guessing sphinx, or some other package in the Python docs build process does some forking. Then sphinx complains withAttributeError: 'function' object has no attribute '__arrow_c_stream__'(the'function'object being the dummy function).