Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python): Don't fail test if e.g. jax has been used first, since jax installs a fork handler that warns #19178

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix(python): Don't fail test if e.g. jax has been used first, since jax installs a fork handler that warns #19178

merged 1 commit into from
Oct 10, 2024

Conversation

itamarst
Copy link
Contributor

@itamarst itamarst changed the title bug(python): Don't fail if e.g. jax has been used first, since jax install fork handler that warns fix(python): Don't fail test if e.g. jax has been used first, since jax installs a fork handler that warns Oct 10, 2024
@github-actions github-actions bot added fix Bug fix python Related to Python Polars and removed title needs formatting labels Oct 10, 2024
stinodego
stinodego approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good to merge if CI is green.

@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.80%. Comparing base (48bc09b) to head (924cf1a).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #19178      +/-   ##
==========================================
- Coverage   79.80%   79.80%   -0.01%     
==========================================
  Files        1532     1532              
  Lines      208500   208500              
  Branches     2418     2418              
==========================================
- Hits       166399   166387      -12     
- Misses      41554    41566      +12     
  Partials      547      547

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 4e59440 into pola-rs:main Oct 10, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itamarst @stinodego @ritchie46 @pythonspeed