Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Reduction -> GroupedReduction for the new streaming engine #19176

Merged
merged 10 commits into from
Oct 10, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Oct 10, 2024

This is necessary preparation for the groupby aggregations in the new streaming engine, it will share the aggregation code with the grouped reductions.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 3.98818% with 650 lines in your changes missing coverage. Please review.

Project coverage is 79.64%. Comparing base (9dada18) to head (0c688b2).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-expr/src/reduce/min_max.rs 0.00% 236 Missing ⚠️
crates/polars-expr/src/reduce/mod.rs 0.00% 168 Missing ⚠️
crates/polars-expr/src/reduce/sum.rs 0.00% 86 Missing ⚠️
crates/polars-expr/src/reduce/mean.rs 0.00% 79 Missing ⚠️
crates/polars-expr/src/reduce/len.rs 0.00% 33 Missing ⚠️
crates/polars-stream/src/nodes/reduce.rs 0.00% 21 Missing ⚠️
crates/polars-arrow/src/bitmap/mutable.rs 54.54% 15 Missing ⚠️
crates/polars-expr/src/reduce/convert.rs 0.00% 7 Missing ⚠️
crates/polars-utils/src/float.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19176      +/-   ##
==========================================
- Coverage   79.78%   79.64%   -0.14%     
==========================================
  Files        1531     1531              
  Lines      208445   208916     +471     
  Branches     2913     2418     -495     
==========================================
+ Hits       166301   166393      +92     
- Misses      41593    41976     +383     
+ Partials      551      547       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlp orlp marked this pull request as ready for review October 10, 2024 13:17
@orlp orlp merged commit 10bd047 into pola-rs:main Oct 10, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant