Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Raise on invalid shape of shape 1, empty combination #19113

Merged
merged 4 commits into from
Oct 6, 2024
Merged

fix: Raise on invalid shape of shape 1, empty combination #19113

merged 4 commits into from
Oct 6, 2024

Conversation

ritchie46
Copy link
Member

fixes #19108

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 6, 2024
ritchie46
ritchie46 commented Oct 6, 2024
View reviewed changes
py-polars/tests/unit/dataframe/test_shape.py
import polars as pl


@pytest.mark.may_fail_auto_streaming
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orlp FYI

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ritchie46 I think we need 'is scalar and thus allowed to broadcast' information into the zip node for that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have is_scalar. Let's discuss tomorrow.

@codecov Codecov
Copy link

codecov bot commented Oct 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.80%. Comparing base (f7de80c) to head (a8bd9c6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...olars-mem-engine/src/executors/projection_utils.rs 80.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #19113   +/-   ##
=======================================
  Coverage   79.80%   79.80%           
=======================================
  Files        1531     1531           
  Lines      208563   208563           
  Branches     2913     2913           
=======================================
+ Hits       166437   166441    +4     
+ Misses      41575    41571    -4     
  Partials      551      551

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 8c306dd into main Oct 6, 2024
24 of 25 checks passed
@ritchie46 ritchie46 deleted the shape branch October 6, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expr.head(0) silently returns 0 rows if other exprs have length of 1
2 participants
@ritchie46 @orlp