feat(python): Add 'drop_empty_rows' parameter for read_excel
#18253
+79
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rashik-raj
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Rashik-raj
force-pushed
the
add-option-to-drop-empty-row-in-excel
branch
from
858ef8c
to
7c8ebe3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18253 +/- ##
=======================================
Coverage 80.23% 80.23%
=======================================
Files 1500 1500
Lines 198871 198883 +12
Branches 2837 2838 +1
=======================================
+ Hits 159556 159582 +26
+ Misses 38788 38774 -14
Partials 527 527 ☔ View full report in Codecov by Sentry. |
Rashik-raj
changed the title
github-actions
bot
added
fix
|
Thanks - I'll look at this shortly 👍 |
alexander-beedie
changed the title
read_excel
github-actions
bot
added
the
enhancement
alexander-beedie
approved these changes
Oct 11, 2024
|
Apologies for the delay in review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: 18250
fixes: 14874
I've added a new flag to maintain backward compatibility for automatically dropping empty rows, allowing users to choose whether or not to drop them in Excel. It seems that dropping empty rows might be necessary for some users, so it could be useful to implement a similar option for other methods, such as
read_csv.