-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(python): Refactor parsing of data type inputs to Polars data types #17164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
An internal refactor or improvement
python
Related to Python Polars
labels
Jun 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17164 +/- ##
==========================================
+ Coverage 80.79% 80.83% +0.04%
==========================================
Files 1464 1465 +1
Lines 191961 192038 +77
Branches 2743 2740 -3
==========================================
+ Hits 155100 155240 +140
+ Misses 36350 36293 -57
+ Partials 511 505 -6 ☔ View full report in Codecov by Sentry. |
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
June 25, 2024 14:27
alexander-beedie
pushed a commit
to alexander-beedie/polars
that referenced
this pull request
Jun 26, 2024
alexander-beedie
pushed a commit
to alexander-beedie/polars
that referenced
this pull request
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #13117
Refactoring the logic that parses dtype inputs to a Polars data type, for example in the
Series
constructor.This is towards improving the logic and consistently applying it across the API.