Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Refactor parsing of data type inputs to Polars data types #17164

Merged
merged 14 commits into from
Jun 26, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jun 24, 2024

Ref #13117

Refactoring the logic that parses dtype inputs to a Polars data type, for example in the Series constructor.

This is towards improving the logic and consistently applying it across the API.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 96.58120% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.83%. Comparing base (0a04ad1) to head (cb953d9).
Report is 1 commits behind head on main.

Files Patch % Lines
py-polars/polars/_utils/construction/series.py 50.00% 2 Missing ⚠️
py-polars/polars/io/csv/batched_reader.py 50.00% 1 Missing ⚠️
py-polars/polars/io/database/_inference.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17164      +/-   ##
==========================================
+ Coverage   80.79%   80.83%   +0.04%     
==========================================
  Files        1464     1465       +1     
  Lines      191961   192038      +77     
  Branches     2743     2740       -3     
==========================================
+ Hits       155100   155240     +140     
+ Misses      36350    36293      -57     
+ Partials      511      505       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review June 25, 2024 14:27
@stinodego stinodego merged commit 048c784 into main Jun 26, 2024
16 checks passed
@stinodego stinodego deleted the parse-dtype branch June 26, 2024 08:43
alexander-beedie pushed a commit to alexander-beedie/polars that referenced this pull request Jun 26, 2024
alexander-beedie pushed a commit to alexander-beedie/polars that referenced this pull request Jun 26, 2024
@c-peters c-peters added the accepted Ready for implementation label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants