fix: Fix corrupted reads for hive parts from cloud and projection pushdown failure on hive parts #17152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
nameexhaustion
force-pushed
the
hive-proj-pd
branch
from
4642ef1
to
20602f0
Compare
nameexhaustion
changed the title
nameexhaustion
commented
Jun 24, 2024
nameexhaustion
commented
Jun 24, 2024
| )); | ||
| }, | ||
| }; | ||
| let is_cloud = is_cloud_url(self.paths.first().unwrap()); |
There was a problem hiding this comment.
Fixed the optimizer to replace a scan with DataFrameScan if the predicate filtered out all files (see below)
nameexhaustion
commented
Jun 24, 2024
| @@ -378,7 +378,7 @@ impl<'a> PredicatePushDown<'a> { | |||
| } | |||
| scan_type.remove_metadata(); | |||
| } | |||
| if paths.is_empty() { | |||
| if new_paths.is_empty() { | |||
There was a problem hiding this comment.
I discovered there was other code in place to ensure the invariant that a reader always has at least one path here, it would replace the scan node with a DataFrameScan but it wasn't being hit because it was incorrectly checking the old paths instead of new_paths. This changes the fix at #12575
nameexhaustion
changed the title
|
Thanks for the quick fix! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17152 +/- ##
==========================================
+ Coverage 80.89% 80.93% +0.03%
==========================================
Files 1456 1456
Lines 191355 191372 +17
Branches 2742 2742
==========================================
+ Hits 154801 154890 +89
+ Misses 36045 35973 -72
Partials 509 509 ☔ View full report in Codecov by Sentry. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17104, #15823 (projection pd)
Fixes #17155 (corrupted reads)