fix(rust): bubble error when no available bitrepr #17116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
This PR refactors the code surrounding bit representations and properly bubbles errors up if no bit representation is defined. This resolves the panic in pola-rs#14826, but does not implement the wanted behavior. I am not sure a test case is useful here as the behavior should be added in the end.
coastalwhite
force-pushed
the
bitrepr-refactor-14826
branch
from
d6354a0
to
4e26830
Compare
ritchie46
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the code surrounding bit representations and properly bubbles errors up if no bit representation is defined.
This resolves the panic in #14826, but does not implement the wanted behavior.
I am not sure a test case is useful here as the behavior should be added in the end.