Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Properly expose InProcessQuery in docs, mark as unstable #17097

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jun 20, 2024

Also remove the top-level re-export. It doesn't need to be re-exported because users do not instantiate it themselves. Similar to GroupBy.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Jun 20, 2024
@stinodego stinodego marked this pull request as ready for review June 20, 2024 21:36
@stinodego stinodego changed the title refactor(python): Properly expose InProcessQuery in docs, mark as unstable docs(python): Properly expose InProcessQuery in docs, mark as unstable Jun 20, 2024
@stinodego stinodego removed the internal An internal refactor or improvement label Jun 20, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.87%. Comparing base (8a6bf4b) to head (a00dc17).

Files Patch % Lines
py-polars/polars/lazyframe/in_process.py 0.00% 5 Missing ⚠️
py-polars/polars/lazyframe/frame.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17097      +/-   ##
==========================================
+ Coverage   80.86%   80.87%   +0.01%     
==========================================
  Files        1456     1456              
  Lines      191141   191141              
  Branches     2728     2728              
==========================================
+ Hits       154562   154584      +22     
+ Misses      36073    36051      -22     
  Partials      506      506              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I made the docs, but never exposed them? :')

@stinodego
Copy link
Member Author

Oh, I made the docs, but never exposed them? :')

Yep 😅

@stinodego stinodego merged commit 3400d74 into main Jun 21, 2024
17 checks passed
@stinodego stinodego deleted the ipq branch June 21, 2024 23:00
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
@c-peters c-peters added the accepted Ready for implementation label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation documentation Improvements or additions to documentation python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants