Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Improve ipython autocomplete for LazyFrame and DataFrame #17091

Merged
merged 3 commits into from
Jun 22, 2024

Conversation

ritchie46
Copy link
Member

Can again confirm that this ensures autocomplete remains working in notebooks.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 97.77778% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.85%. Comparing base (88cfb23) to head (08d9ce6).

Current head 08d9ce6 differs from pull request most recent head e9ba7b6

Please upload reports for the commit e9ba7b6 to get more accurate results.

Files Patch % Lines
py-polars/polars/lazyframe/frame.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17091      +/-   ##
==========================================
- Coverage   80.88%   80.85%   -0.03%     
==========================================
  Files        1456     1456              
  Lines      191155   191155              
  Branches     2731     2731              
==========================================
- Hits       154611   154562      -49     
- Misses      36038    36087      +49     
  Partials      506      506              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit e157bcd into main Jun 22, 2024
13 checks passed
@ritchie46 ritchie46 deleted the types branch June 22, 2024 07:08
@c-peters c-peters added the accepted Ready for implementation label Jun 24, 2024
@borchero
Copy link
Contributor

borchero commented Aug 7, 2024

I just noticed that this also resolves #14741 (albeit for a different purpose 😄) ... thanks! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants