Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow (non-)coalescing in join_asof #17066

Merged
merged 1 commit into from
Jun 19, 2024
Merged

feat: Allow (non-)coalescing in join_asof #17066

merged 1 commit into from
Jun 19, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jun 19, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.86%. Comparing base (8976c2c) to head (f1b5df7).

Files Patch % Lines
py-polars/src/lazyframe/mod.rs 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17066      +/-   ##
==========================================
+ Coverage   80.84%   80.86%   +0.01%     
==========================================
  Files        1455     1455              
  Lines      191014   191020       +6     
  Branches     2723     2723              
==========================================
+ Hits       154431   154467      +36     
+ Misses      36079    36049      -30     
  Partials      504      504

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 535027a into main Jun 19, 2024
19 checks passed
@ritchie46 ritchie46 deleted the join branch June 19, 2024 11:30
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
@ritchie46 @Wouittone
feat: Allow (non-)coalescing in join_asof (pola-rs#17066)
1e86dc9
@c-peters c-peters added the accepted Ready for implementation label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees

@ritchie46 ritchie46

Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ritchie46 @c-peters