-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(python): Clarify explanation and examples for .eq_missing
#17003
base: main
Are you sure you want to change the base?
Conversation
The test failure seems unrelated to the change in this PR; the failure is in
|
.eq_missing()
.eq_missing()
.eq_missing()
.eq_missing
Could you rebase this onto the main branch. I am pretty sure, it will pass the CI if you do that. |
2b77bfb
to
fa9f82f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you also update Series.eq_missing
?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17003 +/- ##
=======================================
Coverage 80.86% 80.86%
=======================================
Files 1455 1455
Lines 191086 191093 +7
Branches 2723 2724 +1
=======================================
+ Hits 154519 154525 +6
- Misses 36063 36064 +1
Partials 504 504 ☔ View full report in Codecov by Sentry. |
That worked. Thanks! |
In py-polars/polars/expr/expr.py Co-authored-by: Stijn de Gooijer <[email protected]>
@stinodego I'm happy to do, but... The pages for So I don't think I'll be able to check the results (a web page built by Sphinx) of updating the If that's correct, perhaps I should hold off for now and do a separate PR when the |
Oops, good catch. I added them :) |
Great, the Series Operators pages now exist. And I made the analogous changes to the Series.eq_missing docstring, both description and Examples. |
@stinodego Could this PR be merged so the Series Operators section's pages will be added (they're still missing in the 1.0 docs), and |
What's needed here? The ambiguity solved here came up in a discussion among core maintainers in #18728 again here. I can try to help with code changes if there's anything remaining here. Otherwise, @mcrumiller or @cmdlineluser, while these discussions are fresh, maybe you can check? |
Fixes #16867 with explanation proposed by @mcrumiller. Provides examples that
.eq_missing()
will returnFalse
whether the number is on the left (the Expr) or right (theother
parameter) when the other value isNone
. For documentation page https://docs.pola.rs/api/python/stable/reference/expressions/api/polars.Expr.eq_missing.html.