refactor(rust): defensively invalidate metadata and start on copying of min_value, max_value and distinct_count
#16593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
github-actions
bot
added
internal
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16593 +/- ##
========================================
Coverage 81.50% 81.51%
========================================
Files 1414 1414
Lines 185669 185850 +181
Branches 3003 3008 +5
========================================
+ Hits 151334 151496 +162
- Misses 33818 33838 +20
+ Partials 517 516 -1 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
May 30, 2024
With this PR, I change the way we clone `ChunkedArray`s. Now, we have to explicitly state after the clone that it is okay to copy over some metadata properties. This clears the way to properly handle other kinds metadata and I implemented such handling for `slice` and `rechunk`.
coastalwhite
force-pushed
the
invalidate-md
branch
from
f422695
to
399078a
Compare
ritchie46
approved these changes
May 30, 2024
Wouittone
pushed a commit
to Wouittone/polars
that referenced
this pull request
Jun 22, 2024
…of `min_value`, `max_value` and `distinct_count` (pola-rs#16593)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, I change the way we clone
ChunkedArrays. Now, we have to explicitly state after the clone that it is okay to copy over some metadata properties. This clears the way to properly handle other kinds metadata and I implemented such handling forsliceandrechunk.