Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Fix boolean trap issue in top_k/bottom_k #16489

Merged
merged 1 commit into from
May 25, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented May 25, 2024

Ref #15238 (comment)

The multithreaded parameter was passed to maintain_order.

We should use keyword arguments to deal with booleans - also when passing it to the PyO3 bindings.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels May 25, 2024
Copy link

codecov bot commented May 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.50%. Comparing base (d68d499) to head (c587af9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16489      +/-   ##
==========================================
+ Coverage   81.42%   81.50%   +0.08%     
==========================================
  Files        1409     1409              
  Lines      184924   184937      +13     
  Branches     2978     2980       +2     
==========================================
+ Hits       150577   150739     +162     
+ Misses      33826    33677     -149     
  Partials      521      521              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Ai.. good catch.

@ritchie46 ritchie46 merged commit 17cf8b7 into main May 25, 2024
22 checks passed
@ritchie46 ritchie46 deleted the fix-top-bottom-k-args branch May 25, 2024 13:06
@c-peters c-peters added the accepted Ready for implementation label May 27, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants