Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improved numeric fill_(forward/backward) #16475

Merged
merged 2 commits into from
May 25, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented May 24, 2024

Closes #15480.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.44%. Comparing base (6de7422) to head (e76170a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16475      +/-   ##
==========================================
- Coverage   81.45%   81.44%   -0.01%     
==========================================
  Files        1409     1409              
  Lines      184746   184810      +64     
  Branches     2971     2971              
==========================================
+ Hits       150482   150520      +38     
- Misses      33744    33770      +26     
  Partials      520      520              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit a1ff7ee into pola-rs:main May 25, 2024
26 checks passed
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forward_fill() and backward_fill() is about 25% slower in polars compared to pandas' counterparts
2 participants