fix(python): respect nan_to_null when using multi-thread in pl.from_pandas
#16459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16459 +/- ##
==========================================
- Coverage 81.46% 81.44% -0.02%
==========================================
Files 1409 1409
Lines 184722 184723 +1
Branches 2971 2971
==========================================
- Hits 150491 150456 -35
- Misses 33711 33747 +36
Partials 520 520 ☔ View full report in Codecov by Sentry. |
|
thanks a tonne for reporting and submitting a fix! no worries, I'll add a test |
Wouittone
pushed a commit
to Wouittone/polars
that referenced
this pull request
Jun 22, 2024
…m_pandas` (pola-rs#16459) Co-authored-by: Marco Gorelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I don't have the time to write a test case at the moment.
Closes #16453