Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): Add general metadata structure to ChunkedArray #16399

Merged
merged 4 commits into from
May 28, 2024

Conversation

coastalwhite
Copy link
Collaborator

This PR adds a general Metadata structure to the ChunkedArray, which can be used to be better informed decisions during the runtime of the query. Currently, it is not always set or used perfectly, but it can be slowly incorperated.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature rust Related to Rust Polars labels May 22, 2024
@coastalwhite coastalwhite force-pushed the prim-array-metadata branch 4 times, most recently from 07eee91 to 2370526 Compare May 23, 2024 13:18
@coastalwhite coastalwhite marked this pull request as ready for review May 23, 2024 13:19
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 81.79612% with 75 lines in your changes are missing coverage. Please review.

Project coverage is 81.51%. Comparing base (d856b49) to head (42ae8f4).

Files Patch % Lines
...polars-core/src/chunked_array/ops/aggregate/mod.rs 48.93% 24 Missing ⚠️
crates/polars-core/src/chunked_array/metadata.rs 79.24% 22 Missing ⚠️
crates/polars-io/src/parquet/read/to_metadata.rs 72.13% 17 Missing ⚠️
crates/polars-core/src/chunked_array/mod.rs 83.33% 8 Missing ⚠️
crates/polars-core/src/chunked_array/from.rs 94.44% 1 Missing ⚠️
...es/polars-core/src/series/implementations/array.rs 50.00% 1 Missing ⚠️
crates/polars-core/src/series/mod.rs 94.73% 1 Missing ⚠️
crates/polars-io/src/parquet/read/read_impl.rs 97.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16399      +/-   ##
==========================================
- Coverage   81.53%   81.51%   -0.02%     
==========================================
  Files        1410     1412       +2     
  Lines      185061   185222     +161     
  Branches     2982     2982              
==========================================
+ Hits       150885   150988     +103     
- Misses      33660    33718      +58     
  Partials      516      516              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added accepted Ready for implementation labels May 27, 2024
@ritchie46
Copy link
Member

Great one @coastalwhite

@ritchie46 ritchie46 merged commit ac8d61a into pola-rs:main May 28, 2024
21 checks passed
@coastalwhite coastalwhite deleted the prim-array-metadata branch May 28, 2024 07:00
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants