Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Implement Struct support for Series.to_numpy #16383

Merged
merged 3 commits into from
May 22, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented May 21, 2024

Ref #14334

We choose to represent Structs as a 2D array. It's constructed by unnesting and calling DataFrame.to_numpy.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.38%. Comparing base (825eb9c) to head (5cf918c).
Report is 1 commits behind head on main.

Files Patch % Lines
py-polars/src/interop/numpy/to_numpy_series.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16383      +/-   ##
==========================================
+ Coverage   81.36%   81.38%   +0.01%     
==========================================
  Files        1406     1406              
  Lines      183911   183911              
  Branches     2954     2954              
==========================================
+ Hits       149648   149676      +28     
+ Misses      33750    33722      -28     
  Partials      513      513              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review May 21, 2024 21:50
@ritchie46 ritchie46 merged commit 48addd5 into main May 22, 2024
18 checks passed
@ritchie46 ritchie46 deleted the series-struct branch May 22, 2024 06:18
@c-peters c-peters added the accepted Ready for implementation label May 27, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants