Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): fix a printing issue in IR::Filter #16378

Merged
merged 1 commit into from
May 22, 2024

Conversation

coastalwhite
Copy link
Collaborator

This resolves a small issue introduced by #16191, where the IR::Filter is printed incorrectly.

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels May 21, 2024
Copy link

codspeed-hq bot commented May 21, 2024

CodSpeed Performance Report

Merging #16378 will degrade performances by 19.01%

Comparing coastalwhite:fix-alp-format-filter-writeln (4306a3a) with main (2c4076e)

Summary

❌ 1 regressions
✅ 36 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main coastalwhite:fix-alp-format-filter-writeln Change
test_tpch_q14 7.1 ms 8.8 ms -19.01%

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.36%. Comparing base (2c4076e) to head (4306a3a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16378      +/-   ##
==========================================
- Coverage   81.38%   81.36%   -0.03%     
==========================================
  Files        1406     1406              
  Lines      183909   183909              
  Branches     2953     2953              
==========================================
- Hits       149679   149642      -37     
- Misses      33717    33754      +37     
  Partials      513      513              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 337ff1f into pola-rs:main May 22, 2024
22 checks passed
@coastalwhite coastalwhite deleted the fix-alp-format-filter-writeln branch May 22, 2024 06:40
@c-peters c-peters added the accepted Ready for implementation label May 27, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants