feat(rust!): Change DataFrame.is_empty() to check height == 0 instead of width == 0
#16351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinodego
changed the title
DataFrame.is_empty() to check height == 0 instead of width == 0DataFrame.is_empty() to check height == 0 instead of width == 0
github-actions
bot
added
breaking rust
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16351 +/- ##
==========================================
- Coverage 81.38% 81.36% -0.02%
==========================================
Files 1406 1406
Lines 183911 183900 -11
Branches 2953 2953
==========================================
- Hits 149671 149627 -44
- Misses 33727 33760 +33
Partials 513 513 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
May 22, 2024
Wouittone
pushed a commit
to Wouittone/polars
that referenced
this pull request
Jun 22, 2024
…tead of `width == 0` (pola-rs#16351)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the method with the Python side.