fix: Address overflow combining u64 hashes in Debug builds #16323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
github-actions
bot
added
fix
alexander-beedie
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16323 +/- ##
=======================================
Coverage 81.35% 81.35%
=======================================
Files 1403 1403
Lines 183463 183463
Branches 2929 2929
=======================================
+ Hits 149253 149259 +6
+ Misses 33707 33701 -6
Partials 503 503 ☔ View full report in Codecov by Sentry. |
alexander-beedie
changed the title
alexander-beedie
changed the title
ritchie46
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent
u64overflow panic when combining AnyValue list-element hashes (in debug builds).