Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: offset=-0i was being treated differently to offset=0i in rolling #16184

Merged
merged 2 commits into from
May 13, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

closes #16168

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels May 13, 2024
@MarcoGorelli MarcoGorelli marked this pull request as ready for review May 13, 2024 09:01
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.99%. Comparing base (3892c75) to head (5b6f8e6).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16184   +/-   ##
=======================================
  Coverage   80.99%   80.99%           
=======================================
  Files        1387     1392    +5     
  Lines      178832   178930   +98     
  Branches     2877     2897   +20     
=======================================
+ Hits       144844   144928   +84     
- Misses      33496    33498    +2     
- Partials      492      504   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 13, 2024

CodSpeed Performance Report

Merging #16184 will improve performances by 18.89%

Comparing MarcoGorelli:negative-zero-offset (5b6f8e6) with main (5a990ff)

Summary

⚡ 1 improvements
✅ 34 untouched benchmarks

Benchmarks breakdown

Benchmark main MarcoGorelli:negative-zero-offset Change
test_tpch_q8 22.9 ms 19.3 ms +18.89%

@ritchie46 ritchie46 merged commit 3a630ec into pola-rs:main May 13, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difference between 0i and -0i when used as .rolling() offset
2 participants