Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Create NumPy view for Datetime/Duration Series on the Rust side #16148

Merged
merged 4 commits into from
May 10, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented May 10, 2024

Ref #14334

Changes

  • Update the create_borrowed_np_array util to take a dtype parameter with the desired numpy dtype.
  • Add support for views on Datetime/Duration Series (and remove the workaround on the Python side).

Some more work required to also support views on DataFrames with datetime/duration types, will do in another PR.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels May 10, 2024
@stinodego stinodego changed the title refactor(python): Create numpy view for Datetime/Duration Series on the Rust side refactor(python): Create NumPy view for Datetime/Duration Series on the Rust side May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 97.87234% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.96%. Comparing base (c4e8678) to head (c577af3).
Report is 2 commits behind head on main.

Files Patch % Lines
py-polars/src/to_numpy.rs 97.82% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16148   +/-   ##
=======================================
  Coverage   80.96%   80.96%           
=======================================
  Files        1386     1386           
  Lines      178437   178520   +83     
  Branches     2882     2881    -1     
=======================================
+ Hits       144463   144536   +73     
- Misses      33480    33491   +11     
+ Partials      494      493    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review May 10, 2024 10:33
@ritchie46 ritchie46 merged commit e94daa6 into main May 10, 2024
19 checks passed
@ritchie46 ritchie46 deleted the numpy-temporal-view branch May 10, 2024 11:22
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants