Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(python): Update tests for new connectorx (now works with 3.12) #16146

Merged
merged 1 commit into from
May 10, 2024

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented May 10, 2024

New connectorx release (0.3.3) this morning - supports Python 3.12! 🎉

  • Updated unit tests to remove the conditional skip on 3.12.
  • Updated dev requirements so we don't constrain install to <= 3.11.

@github-actions github-actions bot added the internal An internal refactor or improvement label May 10, 2024
@alexander-beedie alexander-beedie added the test Related to the test suite label May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.95%. Comparing base (c4e8678) to head (d45cf39).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16146      +/-   ##
==========================================
- Coverage   80.96%   80.95%   -0.01%     
==========================================
  Files        1386     1386              
  Lines      178437   178437              
  Branches     2882     2882              
==========================================
- Hits       144463   144455       -8     
- Misses      33480    33489       +9     
+ Partials      494      493       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Nice one!

@ritchie46 ritchie46 merged commit b2291b9 into pola-rs:main May 10, 2024
20 checks passed
@alexander-beedie alexander-beedie deleted the update-connectorx-312 branch May 10, 2024 08:10
@mcrumiller
Copy link
Contributor

Whoa, I figured connectorx was dead. Good news!

Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement test Related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants