fix(python): Fix Series constructor failure for Array types for large integers #16050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
stinodego
changed the title
github-actions
bot
added
fix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16050 +/- ##
=======================================
Coverage 80.96% 80.97%
=======================================
Files 1386 1386
Lines 178385 178385
Branches 3060 3060
=======================================
+ Hits 144438 144441 +3
+ Misses 33460 33452 -8
- Partials 487 492 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
stinodego
force-pushed
the
array-u64-construction
branch
from
75173e6
to
c010986
Compare
stinodego
commented
May 5, 2024
Comment on lines
+165
to
+166
|
|
||
| if python_dtype is None: |
There was a problem hiding this comment.
Drive-by: dedenting this block.
2 tasks
Wouittone
pushed a commit
to Wouittone/polars
that referenced
this pull request
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16033
This should make it take the same path as List types.