-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Decimal read from IPC #15965
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15965 +/- ##
==========================================
+ Coverage 74.36% 80.89% +6.53%
==========================================
Files 1367 1384 +17
Lines 169193 178047 +8854
Branches 3043 3043
==========================================
+ Hits 125818 144036 +18218
+ Misses 42892 33527 -9365
- Partials 483 484 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Coverage got ratelimited
|
) | ||
}; | ||
// Now we need to keep the new buffer alive | ||
struct Two<A, B>(A, B); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use a tuple directly. E.g. (A, B)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that idea, a lot :D
CodSpeed Performance ReportMerging #15965 will improve performances by 17.13%Comparing Summary
Benchmarks breakdown
|
Resolves #15920
128-bit values could be unaligned, in which case we need to do a copy (
write_ipc
currently doesn't align them).