Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Decimal read from IPC #15965

Merged
merged 3 commits into from
May 1, 2024
Merged

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Apr 30, 2024

Resolves #15920

128-bit values could be unaligned, in which case we need to do a copy (write_ipc currently doesn't align them).

@nameexhaustion nameexhaustion self-assigned this Apr 30, 2024
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 93.22034% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 80.89%. Comparing base (c9e786b) to head (0ef7b2c).

Files Patch % Lines
crates/polars-arrow/src/mmap/array.rs 94.82% 3 Missing ⚠️
crates/polars-arrow/src/array/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15965      +/-   ##
==========================================
+ Coverage   74.36%   80.89%   +6.53%     
==========================================
  Files        1367     1384      +17     
  Lines      169193   178047    +8854     
  Branches     3043     3043              
==========================================
+ Hits       125818   144036   +18218     
+ Misses      42892    33527    -9365     
- Partials      483      484       +1     
Flag Coverage Δ
python 74.37% <93.22%> (+<0.01%) ⬆️
rust 78.03% <93.22%> (+6.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion
Copy link
Collaborator Author

Coverage got ratelimited

error - 2024-04-30 09:29:27,115 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 339 seconds."}

)
};
// Now we need to keep the new buffer alive
struct Two<A, B>(A, B);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use a tuple directly. E.g. (A, B).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that idea, a lot :D

Copy link

codspeed-hq bot commented May 1, 2024

CodSpeed Performance Report

Merging #15965 will improve performances by 17.13%

Comparing nameexhaustion:ipc (0ef7b2c) with main (c9e786b)

Summary

⚡ 1 improvements
✅ 34 untouched benchmarks

Benchmarks breakdown

Benchmark main nameexhaustion:ipc Change
test_tpch_q15 7.8 ms 6.7 ms +17.13%

@ritchie46 ritchie46 merged commit 31eaabe into pola-rs:main May 1, 2024
25 checks passed
@nameexhaustion nameexhaustion deleted the ipc branch May 1, 2024 10:53
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does polars supporte Decimal128 parse from IPC files?
2 participants