Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python): Change recognition of numba ufunc #15916

Merged
merged 8 commits into from
Apr 28, 2024
Merged

fix(python): Change recognition of numba ufunc #15916

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
674d834
fix(python): Change recognition of numba ufunc
deanm0000 Apr 26, 2024
ab2b7be
make typer happy
deanm0000 Apr 26, 2024
b0d1f55
make typer happy2
deanm0000 Apr 26, 2024
28e5fea
typing import
deanm0000 Apr 26, 2024
db31a3e
typeout
deanm0000 Apr 26, 2024
48cb705
typeout2
deanm0000 Apr 26, 2024
53984cc
oopscallable
deanm0000 Apr 26, 2024
90e9d19
retry test
deanm0000 Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion py-polars/polars/expr/expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,8 @@ def __array_ufunc__(
if method != "__call__":
msg = f"Only call is implemented not {method}"
raise NotImplementedError(msg)
is_custom_ufunc = ufunc.__class__ != np.ufunc
# Numpy/Scipy ufuncs have signature None but numba signatures always exists.
is_custom_ufunc = getattr(ufunc, "signature") is not None # noqa: B009
num_expr = sum(isinstance(inp, Expr) for inp in inputs)
exprs = [
(inp, Expr, i) if isinstance(inp, Expr) else (inp, None, i)
Expand Down
Loading