Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rust): remove try_binary_elementwise_values #15592

Merged

Conversation

MarcoGorelli
Copy link
Collaborator

First, this is unused. And second, even if it was used, a similar argument to applies #15336 - should people be using it at all?

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Apr 11, 2024
@MarcoGorelli MarcoGorelli marked this pull request as ready for review April 11, 2024 10:10
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.15%. Comparing base (05d980f) to head (70c2b01).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15592      +/-   ##
==========================================
+ Coverage   81.13%   81.15%   +0.01%     
==========================================
  Files        1367     1367              
  Lines      174984   174921      -63     
  Branches     2530     2530              
==========================================
- Hits       141971   141951      -20     
+ Misses      32536    32493      -43     
  Partials      477      477              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Apr 11, 2024

CodSpeed Performance Report

Merging #15592 will improve performances by 19.01%

Comparing MarcoGorelli:remove-try-binary-elementwise-values (70c2b01) with main (05d980f)

Summary

⚡ 1 improvements
✅ 21 untouched benchmarks

Benchmarks breakdown

Benchmark main MarcoGorelli:remove-try-binary-elementwise-values Change
test_windows_not_cached 3.6 s 3 s +19.01%

@reswqa
Copy link
Collaborator

reswqa commented Apr 11, 2024

Yes, propagate error raised by the value behind null is really not a good direction.

@orlp orlp merged commit f329b5c into pola-rs:main Apr 11, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants